|
|
|
[
Permlink
| « Hide
]
Sean Laurent - 30/Dec/08 04:47 PM
Patch against the 2.0 release at r1089 (unitils/tags/releases/unitils-2.0).
Hopefully the patch is still useful. Let me know if you need me to adjust it and resubmit, I would be happy to do so.
Thanks but it's not needed. The patch still works after a little bit of hassling, but I won't just apply it anyway since I'm currently busy refactoring the scriptparser. Since the stored procedure support is very similar for most dbms-es I will try to come to as few as possible dbms-specific code. Your patch is useful anyway: I can take over the method that recognizes the start of a PostgreSQL stored procedure and use the test to make sure it still works.
There was a bug in your patch: the regular expression that you're using: CREATE (OR REPLACE)? FUNCTION expects 2 whitespaces between 'CREATE' and 'FUNCTION' if you're not using 'OR REPLACE'. It should be CREATE (OR REPLACE )?FUNCTION.
Sorry about the delay in responding. Doesn't sound like you really need an updated patch, but I fixed the regexp mistake and attached a new version of the patch. Let me know if there is anything else I can do to help.
Fixed in revision 183 (along with a thorough refactoring of the script parser)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||